[BACKPORT 25.10] Add spot interruption tracking to trace records (#6606) #6674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fntlnz
force-pushed
the
backport/6606-spot-interruption-tracking
branch
from
bf2119b to
db6e9a4
Compare
plugins/nf-amazon/src/test/nextflow/cloud/aws/batch/AwsBatchTaskHandlerTest.groovy
Outdated
Show resolved
Hide resolved
Track and report spot/preemptible instance interruptions for cloud batch executors. Changes: - Add `numSpotInterruptions` transient field to TraceRecord - AWS Batch: detect spot interruptions by checking status reason pattern "Host EC2*" - Google Batch: detect spot preemptions via exit code 50001 in status events - Tower plugin: send numSpotInterruptions to Seqera Platform telemetry This enables workflow optimization and cost analysis by tracking how often tasks are retried due to spot instance reclamation. (cherry picked from commit eecd816) Signed-off-by: Lorenzo Fontana <[email protected]>
fntlnz
force-pushed
the
backport/6606-spot-interruption-tracking
branch
from
db6e9a4 to
b62f0e6
Compare
munishchouhan
approved these changes
Dec 18, 2025
pditommaso
requested changes
Dec 18, 2025
Member
pditommaso
left a comment
pditommaso
left a comment
There was a problem hiding this comment.
Look good, just not merge yet
pditommaso
reviewed
Jan 13, 2026
| def trace = handler.getTraceRecord() | ||
| then: | ||
| 1 * handler.isCompleted() >> false | ||
| 2 * handler.isCompleted() >> false |
Member
There was a problem hiding this comment.
Not sure to understand why this changed to 2
Collaborator
There was a problem hiding this comment.
because another call is added to isCompleted in the getNumSpotInterruptions method.
Since here we are testing getTraceRecord() method which already have one call to isCompleted()
There was a problem hiding this comment.
What's the resolution here?
Collaborator
There was a problem hiding this comment.
there is one call here
and another call is added here
Both are in getTraceRecord() method
we can remove one from getNumSpotInterruptions, it a separate method, so if it called somewhere else where isCompleted is not called then that can lead to an issue
Member
There was a problem hiding this comment.
yeah, I think this check !isCompleted() is not really needed
plugins/nf-amazon/src/main/nextflow/cloud/aws/batch/AwsBatchTaskHandler.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-amazon/src/test/nextflow/cloud/aws/batch/AwsBatchTaskHandlerTest.groovy
Outdated
Show resolved
Hide resolved
plugins/nf-google/src/main/nextflow/cloud/google/batch/GoogleBatchTaskHandler.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Munish Chouhan <[email protected]>
plugins/nf-google/src/test/nextflow/cloud/google/batch/GoogleBatchTaskHandlerTest.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Munish Chouhan <[email protected]>
Signed-off-by: Munish Chouhan <[email protected]>
Signed-off-by: Munish Chouhan <[email protected]>
Signed-off-by: Munish Chouhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
numSpotInterruptionsfield to trace records for Tower/Platform telemetry:(cherry picked from commit eecd816)